Merge pull request #448 from gkjohnson/reverse-simplification

Revert "Remove unnecessary check"
gkjohnson · Jul 20, 2023 · d08fa08 · d08fa08
2 parents fba1350 + cf3fb9f
commit d08fa08
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/materials/pathtracing/glsl/directLightContribution.glsl.js b/src/materials/pathtracing/glsl/directLightContribution.glsl.js
@@ -29,7 +29,8 @@ export const directLightContributionGLSL = /*glsl*/`
 				// get the material pdf
 				vec3 sampleColor;
 				float lightMaterialPdf = bsdfResult( worldWo, lightRec.direction, surf, sampleColor );
-				if ( lightMaterialPdf > 0.0 ) {
+				bool isValidSampleColor = all( greaterThanEqual( sampleColor, vec3( 0.0 ) ) );
+				if ( lightMaterialPdf > 0.0 && isValidSampleColor ) {
 
 					// weight the direct light contribution
 					float lightPdf = lightRec.pdf / lightsDenom;
@@ -71,7 +72,8 @@ export const directLightContributionGLSL = /*glsl*/`
 				// get the material pdf
 				vec3 sampleColor;
 				float envMaterialPdf = bsdfResult( worldWo, envDirection, surf, sampleColor );
-				if ( envMaterialPdf > 0.0 ) {
+				bool isValidSampleColor = all( greaterThanEqual( sampleColor, vec3( 0.0 ) ) );
+				if ( envMaterialPdf > 0.0 && isValidSampleColor ) {
 
 					// weight the direct light contribution
 					envPdf /= lightsDenom;