Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescaped quotes #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Unescaped quotes #21

wants to merge 2 commits into from

Conversation

nim579
Copy link

@nim579 nim579 commented Jun 22, 2016

I've stumbled upon some rather common case with some CSV vendor's files. For expample, IMDB's exports have unesceped quotes between column separators, like this: (NB: Superman Lives)

"position","const","created","modified","description","Title","Title type","Directors","You rated","IMDb Rating","Runtime (mins)","Year","Genres","Num. Votes","Release Date (month/day/year)","URL"
"1","tt2753778","Thu Feb  4 00:00:00 2016","","","The Death of "Superman Lives": What Happened?","Documentary","Jon Schnepp","7","7.1","104","2015","documentary","3034","2015-04-30","http://www.imdb.com/title/tt2753778/"

So I supported this case. Test are included.

@gkindel
Copy link
Owner

gkindel commented Jun 24, 2016

Sounds like a good use case, thanks for the change! I'll take a look at the diff this weekend.

@gkindel gkindel self-assigned this May 12, 2017
@gkindel
Copy link
Owner

gkindel commented May 12, 2017

I'll merge this in with under the lax setting, but will need to be off for strict.

@nim579
Copy link
Author

nim579 commented May 12, 2017

Sorry I don't understand what do you mean. I'm ready for support this feature :)

P.S. I'd rebased my pull request on new master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants