Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alpha functionality to bezier interpolation #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FaithForHumans
Copy link

No description provided.

bluelovers added a commit to bluelovers/ws-color that referenced this pull request Jun 17, 2020
@regorxxx
Copy link

regorxxx commented Nov 7, 2023

Your implementation is wrong for 5 points, those are not the results.

Note in all cases, the alpha and not alpha tests match except the last 2 digits on the Hex values. In your pull request, the 5-point solution does not.

Also you have replaced the n-degree method with a hard-coded 4-degree one, therefore failing for anything greater than that.

See this for a proper implementation of n-degree Bezier:
regorxxx@48a86d2

@regorxxx regorxxx mentioned this pull request Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants