Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLib.Error.stack property #201

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

swsnr
Copy link
Contributor

@swsnr swsnr commented Sep 5, 2024

Fixes #196

@swsnr
Copy link
Contributor Author

swsnr commented Sep 5, 2024

@JumpLink This is mostly an educated guess, from looking at other injection files. Is this correct? How do I test this locally?

@swsnr
Copy link
Contributor Author

swsnr commented Sep 5, 2024

Okay, I managed to run yarn build:types:packages:gtk4 and now GLib.Error in @types/glib-2.0 has a stack field:

GLib.Error

So presumably, this works?

@swsnr swsnr marked this pull request as ready for review September 5, 2024 06:32
@swsnr
Copy link
Contributor Author

swsnr commented Sep 19, 2024

@JumpLink Would you take a look?

@JumpLink
Copy link
Collaborator

@swsnr Sorry for the late response, I'm still on parental leave at the moment. Looks good for me, thanks for the contribution!

@JumpLink JumpLink merged commit f483b4d into gjsify:main Sep 20, 2024
2 checks passed
@swsnr swsnr deleted the 196-add-glib-error-stack branch September 20, 2024 12:42
@swsnr
Copy link
Contributor Author

swsnr commented Sep 20, 2024

Oh sorry, wasn't aware 😇

Thanks for merging ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLib.Error.stack missing
2 participants