copy command #162

JumpLink · 2024-04-11T20:05:35Z

This PR adds a new copy command to scan for *.gir files and copy them to a new directory. We want to use this to copy the newest GIR files found on the developer machines to this repository.

To copy all the latest GIR files from your machine into this repository just run yarn copy:girs .

Changes

Moved XML parsing to DependencyManager to be able to compare the library versions of the found dependencies
Allow glob patterns for GIR directories to search in
Allow glob patterns for GIR ignore list
New copy command
General clean-up like removing unused code
Split module loading and parsing to omitted the parsing for the list and copy commands
Logger output improved and more used
Compare GIR library versions and use the latest one
Copied the GIR files of my machine into this repository
Bump version 4.0.0-beta.3
Published ts-for-gir v4.0.0-beta.3 of this PR with the next tag
Published all generated types of this PR with the next tag
Added a helper shell script to find all Fedora packages which contains at least one *.gir file

JumpLink · 2024-04-18T07:20:36Z

I think I'll soon be finished with the copy command, the only thing missing is the library version comparison. @ewlsh maybe you would like to have a look at this PR? I'm sorry that it has become so extensive again 😅

JumpLink · 2024-04-18T14:47:12Z

@ewlsh Should be finished now, feel free to also update the GIR files from you machine into this PR or as soon as this is merged 👍

JumpLink · 2024-04-30T07:36:42Z

@ewlsh ping

JumpLink · 2024-05-03T20:39:16Z

Positive feedback for the packages published of this PR on gjsify/gnome-shell#39 👍

.ts-for-gir.copy-all.rc.js

examples/gjs/adw-1-hello/package.json

ewlsh · 2024-05-07T14:26:57Z

packages/cli/src/commands/copy.ts

@@ -0,0 +1,94 @@
+/**


Could we default to a list of directories based on XDG_DATA_DIRS and print what directories we are searching?

We could construct the shell and mutter directories based on the data directories too.

We already checking XDG_DATA_DIRS as long as no search directories are passed.

I'm happy to add logging for the search directories

ewlsh · 2024-05-07T14:31:41Z

packages/lib/src/dependency-manager.ts

@@ -88,49 +125,241 @@ export class DependencyManager extends GirNSRegistry {
            : `import type ${namespace} from '${importPath}';`
    }

+    protected async parseGir(path: string) {


Caching the XML in my experience tends to lead to memory issues because you're caching massive strings for each library processed while the command is running. I don't think there is a need to cache the XML anymore, is there?

I have to parse the xml to extract the version number to compare the gir files for the copy command and so that I don't have to parse the xml again for the "real" gir parsing - I cache it, but after that we could delete it. Do you think that would make sense?

I would cache the version number itself, caching the XML structure or parsed XML adds a lot of memory usage which will/does require increasing node's memory limits. Reading from disk and re-parsing is not particularly expensive in the grand scheme of things.

Okay, I will implement it like this

packages/lib/src/utils.ts

ewlsh · 2024-05-07T14:33:22Z

packages/lib/src/validators/interface.ts

@@ -10,7 +10,7 @@ export class InterfaceVisitor extends GirVisitor {

            if (!GObject) {
                throw new Error(
-                    `GObject.Object could not be found while generating ${node.namespace.name}.${node.name}`
+                    `GObject.Object could not be found while generating ${node.namespace.namespace}.${node.name}`


I think the original was correct 🤔

I'll have another look, I think I had renamed the proboerty

Sorry for the slow turn around, I find this renaming a bit confusing. namespace.name matches the pattern elsewhere.

I see this is aligning the previous properties in GirModule which calls the prop namespace, I still find it confusing but I don't think this is a blocking issue.

ewlsh · 2024-05-07T14:35:07Z

girs/Adw-1.gir

@@ -5151,6 +5151,9 @@ If the value is 0, the number of lines won't be limited.</doc>
        <type name="PreferencesRowClass" c:type="AdwPreferencesRowClass"/>


GIRs as a submodule might make sense in the future. types we usually have to update in MRs, but girs does not have as tight a dependency.

Alternatively I think you can flag files as "binary" to avoid them spamming MR review but I'm not sure that is ideal unless we have a CI check that validates the GIRs are unedited.

yes, it makes sense to move them to a submodule, I can do that

maybe the gir files are also interesting for other projects (like we used the ones from vala), so I think a submodule would be useful

Would be good as a follow up

ewlsh

I've left comments, the only one I think is high priority is avoiding caching the XML. But that could be done in a follow up MR given the length of this one.

JumpLink · 2024-05-14T14:42:36Z

@ewlsh That would be great, as I don't have much time at the moment, then this could already be merged and I will do that later

JumpLink added 6 commits April 11, 2024 21:27

chore: Upgrade dependencies

ab4e7cb

fix(cli): Fix thrown error on list command

6c5fcc3

feat(copy): Add initial copy command

eddcf5f

feat(cli): Add glob pattern support for gir directories

0bbfdaa

chore: Revert test package and upgrade rollup

f96c43f

chore: Move XML parsing to DependencyManager

ff06e9f

JumpLink marked this pull request as ready for review April 15, 2024 20:03

JumpLink added 10 commits April 15, 2024 22:10

fix: Circular self reference

5ca4992

fix: Initialisation of GirModule

2692bf5

chore(github): Run CI on Pull Requests

141a33c

fix: yarn.lock

63c01cc

chore(types): Move types to types dir

88c86f6

fix: ModuleLoader: transitive module dependencies

fa45033

fix: Ignored gir module pattern

98850fc

fix: template placeholder and remove CommonJS

39d5f9f

chore(TypeIdentifier): Use dependency instead of namespace

83634b5

chore(TypeIdentifier): Revert usage of dependency instead of namespace

78fa094

JumpLink requested a review from ewlsh April 18, 2024 07:20

JumpLink added 2 commits April 18, 2024 16:44

feat(copy): Parse library version and use the latest

1ef2b71

chore(girs): Update gir files

ef34b82

JumpLink mentioned this pull request Apr 18, 2024

Finalise the ts-for-gir and gi.ts fusion #158

Open

11 tasks

JumpLink added 7 commits April 18, 2024 16:56

chore: Update generated types

ff8f25e

chore: Upgrade dependencies

d61099a

chore: Add more gir files and bump version 4.0.0-beta.3

11ed095

chore: Add shell script to find packages with gir files on fedora

e252946

chore(girs): Update and add more GIR files

d68e829

chore: Update git types submodule

f0769fc

chore: Upgrade dependencies

e18c7d0

JumpLink mentioned this pull request Apr 22, 2024

Upgrade gir dependencies to x.x.x-4.0.0-beta.3 gjsify/gnome-shell#35

Merged

JumpLink added 2 commits April 23, 2024 19:40

chore(girs): Copy GIR files from Fedora 40

a81c849

chore: Update types submodule

228e729

Add /usr/lib/mutter-* gir search path, fixes #167

9c7ccfe

JumpLink mentioned this pull request May 3, 2024

Add /usr/lib/mutter-13 to default search paths #167

Closed

JumpLink added 3 commits May 3, 2024 16:00

Upgrade dependencies

d6b6223

chore: Update gir files

90e1e6c

Resolve merge conflict

30c58be

chore: Bump version 4.0.0-beta.5

b36d5f8

ewlsh requested changes May 7, 2024

View reviewed changes

fix(cli): Moved prettier from dev-deps to deps

a675f79

ewlsh approved these changes May 14, 2024

View reviewed changes

JumpLink merged commit 978c3b7 into main May 14, 2024
2 checks passed

JumpLink mentioned this pull request Jul 19, 2024

Allow to toggle between package.json support + further cleanups from the gi.ts merge #176

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

copy command #162

copy command #162

JumpLink commented Apr 11, 2024 •

edited

Loading

JumpLink commented Apr 18, 2024

JumpLink commented Apr 18, 2024 •

edited

Loading

JumpLink commented Apr 30, 2024

JumpLink commented May 3, 2024

ewlsh May 7, 2024

JumpLink May 7, 2024

ewlsh May 7, 2024 •

edited

Loading

JumpLink May 7, 2024 •

edited

Loading

ewlsh May 14, 2024 •

edited

Loading

JumpLink May 14, 2024

ewlsh May 7, 2024

JumpLink May 7, 2024

ewlsh May 14, 2024

ewlsh May 14, 2024

ewlsh May 7, 2024

ewlsh May 7, 2024 •

edited

Loading

JumpLink May 7, 2024

JumpLink May 7, 2024

ewlsh May 14, 2024

ewlsh left a comment

JumpLink commented May 14, 2024

		@@ -5151,6 +5151,9 @@ If the value is 0, the number of lines won't be limited.</doc>
		<type name="PreferencesRowClass" c:type="AdwPreferencesRowClass"/>

copy command #162

copy command #162

Conversation

JumpLink commented Apr 11, 2024 • edited Loading

Changes

JumpLink commented Apr 18, 2024

JumpLink commented Apr 18, 2024 • edited Loading

JumpLink commented Apr 30, 2024

JumpLink commented May 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewlsh May 7, 2024 • edited Loading

Choose a reason for hiding this comment

JumpLink May 7, 2024 • edited Loading

Choose a reason for hiding this comment

ewlsh May 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewlsh May 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ewlsh left a comment

Choose a reason for hiding this comment

JumpLink commented May 14, 2024

JumpLink commented Apr 11, 2024 •

edited

Loading

JumpLink commented Apr 18, 2024 •

edited

Loading

ewlsh May 7, 2024 •

edited

Loading

JumpLink May 7, 2024 •

edited

Loading

ewlsh May 14, 2024 •

edited

Loading

ewlsh May 7, 2024 •

edited

Loading