-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for rounded-window-corners #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a @version 46
annotation comment to all exported classes; this helps us keep track of things across Gnome major upgrades.
Take a look at the code to see how these comments should look like.
Done |
@flexagoon CI complains about formatting; you'll need to run prettier on the code. |
Oh, formatting is failing because they got formatted by the typescript lsp Sure, I'll run prettier on my changes |
@swsnr ok, the formatting should be fixed now |
Seems good, thank you for your contribution ❤️ |
@Totto16 how often does this library get new releases? When will I be able to use the contributed types? |
That depends on the amount of commits, we usually don't make releases with just 1-2 commits / changes. But I am working on some things today, so likely today. And if I wasn't we / I could just make a release, that would be possible too, but we try to batch them together. Feel free to subscribe to releases in this repo, as we always make a GitHub (Pre)-release too, so you get a notification ❤️ |
Use newer type annotation versions which include all required type annotations (missing annotations were added by me[1]). This removes the need for the @imports folder and ensures that all code is strictly typed. [1]: gjsify/gnome-shell#42
Use newer type annotation versions which include all required type annotations (missing annotations were added by me[1]). This removes the need for the imports folder and ensures that all code is strictly typed. [1]: gjsify/gnome-shell#42
Add extra types required for the https://github.com/flexagoon/rounded-window-corners extension