Fix errors on line plots #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an error that if the `line` has only one data point, looking at `line[1]` will cause an index out of bounds error. I suspect you wanted to look at the previous value, which would be `line[i-1]` instead of `line[1]` correct? I added a simple check not to try and calculate the value if we are on the first item. Please feel free to reject this PR but it fixed a crash in my program and did not alter the output in any noticeable way so I'm gonna use it regardless.
|
Honestly I may need to look at this again... Every time I think I fixed it, it crashes again. Every single time it's just bad indexing in the plot function, I need to look closer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a plot only has one data point, the code will make it go out of bounds (at index one). Test this by going to the example and setting
And it will crash.
Now it checks the
ith element instead of one, and starts reading the data from0instead of1.