Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: username discriminator #1086

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix: username discriminator #1086

merged 1 commit into from
Jun 20, 2023

Conversation

Vyvy-vi
Copy link
Collaborator

@Vyvy-vi Vyvy-vi commented Jun 19, 2023

This PR adjusts to the recent updates dobe by discord, and drops the discriminator tag from the username

fixes #1088

@Vyvy-vi
Copy link
Collaborator Author

Vyvy-vi commented Jun 19, 2023

related to https://discord.com/channels/1075650257574166628/1075673041746546718/1119305673004552325

We might need to make a migration for the praise usernames that have 0 appended to them due to this bug

@kristoferlund kristoferlund self-requested a review June 20, 2023 13:32
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the quick fix.

@kristoferlund kristoferlund merged commit de3f943 into main Jun 20, 2023
1 check passed
@kristoferlund kristoferlund deleted the fix/usernames branch June 20, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username generation should strip trailing #0 from "new" Discord usernames
2 participants