fix: remove failed update

givepraise · Jun 30, 2023 · bc5796c · bc5796c
1 parent 61d1f68
commit bc5796c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/packages/discord-bot/src/handlers/praise.ts b/packages/discord-bot/src/handlers/praise.ts
@@ -97,6 +97,7 @@ export const praiseHandler: CommandHandler = async (
           );
 
           if (giverAccount && giverAccount.user) {
+            await collector.stop();
             await givePraise(
               interaction,
               guild,
@@ -108,6 +109,7 @@ export const praiseHandler: CommandHandler = async (
               host,
               responseUrl
             );
+            return;
           }
 
           await i.update({

diff --git a/packages/discord-bot/src/utils/givePraise.ts b/packages/discord-bot/src/utils/givePraise.ts
@@ -82,6 +82,7 @@ export const givePraise = async (
       ],
       components: [],
     });
+
     praiseItems = await createPraise(
       interaction,
       giverAccount,
@@ -124,16 +125,12 @@ export const givePraise = async (
   const warningMsgParts: string[] = [];
 
   if (parsedReceivers.undefinedReceivers) {
-    const warning = await renderMessage(
-      'PRAISE_UNDEFINED_RECEIVERS_WARNING',
-      host,
-      {
-        receivers: parsedReceivers.undefinedReceivers.map((id) =>
-          id.replace(/[<>]/, '')
-        ),
-        user: member.user,
-      }
-    );
+    const warning = await renderMessage('', host, {
+      receivers: parsedReceivers.undefinedReceivers.map((id) =>
+        id.replace(/[<>]/, '')
+      ),
+      user: member.user,
+    });
     warningMsgParts.push(warning);
   }