Merge pull request #1116 from givepraise/fix/quant-assignment-bug

Fix quantifier assignment bug affecting
givepraise · Jul 24, 2023 · a587d47 · a587d47
2 parents 8c8d738 + 0d16916
commit a587d47
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/packages/api/src/periods/services/period-assignments.service.ts b/packages/api/src/periods/services/period-assignments.service.ts
@@ -99,16 +99,12 @@ export class PeriodAssignmentsService {
     let response;
 
     if (PRAISE_QUANTIFIERS_ASSIGN_EVENLY) {
-      // When quantifiers are assigned evenly, the quantifier pool size needed
-      // is the number of quantifiers per praise receiver plus one.
-      const quantifierPoolSizeNeeded =
-        PRAISE_QUANTIFIERS_PER_PRAISE_RECEIVER + 1;
       response = {
         quantifierPoolSize,
-        quantifierPoolSizeNeeded,
+        quantifierPoolSizeNeeded: PRAISE_QUANTIFIERS_PER_PRAISE_RECEIVER,
         quantifierPoolDeficitSize:
-          quantifierPoolSizeNeeded > quantifierPoolSize
-            ? quantifierPoolSizeNeeded - quantifierPoolSize
+          PRAISE_QUANTIFIERS_PER_PRAISE_RECEIVER > quantifierPoolSize
+            ? PRAISE_QUANTIFIERS_PER_PRAISE_RECEIVER - quantifierPoolSize
             : 0,
       };
     } else {