Push with refspec #2542
Open
Push with refspec #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As prev. behavior was pushing without `brach.*.merge` check, situation like `r1branch.merge = refs/heads/master` would end up pushing to remote r1branch. Which is changed in prev. commits. New behavior would push to remote master To comply with tests, this commit enchance `clone_branch_commit_push` by _explicitly_ resetting branch upstream. So on push it will create new remote ref, as nothing was configured. This behavior is expected to happen in `test_remotes_of_branches` test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2537
git2 merged necessary PR
This PR is_blocked until new version git2 lib released
For now use git2 from master to be able to test PR.
Assume git config:
Prev. behavior:
push -> push oblava -> remote oblava <- new remote created
New behavior:
push -> push oblava -> remote master
I followed the checklist:
make checkwithout errors (see commit with tests fixes)