Profile Settings Modal has no feedback for user data loading state #179
Conversation
- A custom skeleton component is added which can be used further - Two loading states are there one for when the profile details are loading and the other when the user submits the form
|
@madhav-relish is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
madhav-relish
changed the title
madhav-relish
changed the title
|
Hi @madhav-relish, mantine modals are being used everywhere |
|
Hi @nevo-david Didn't see much of mantine/core being used, otherwise I would've used the skeleton from that only. Let me know if you need any changes in this PR. |
|
@madhav-relish , would you mind resolving the merge conflict? Thanks. |
jamesread
changed the title
|
Sure, will do! |
|
@madhav-relish , many thanks, I've just approved the CI to run. I'll let @nevo-david decide on if this is the right direction for the code for now, as I'm mostly focussing on infrastructure stuff :-) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <img | ||
| src={picture?.path} | ||
| alt="profile" | ||
| className="w-full h-full rounded-full" | ||
| /> |
Check warning
Code scanning / ESLint
Prevent usage of `<img>` element due to slower LCP and higher bandwidth. Warning
Alrighty! :) |
Fixes: #177
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Profile Settings Modal has no feedback for user data loading state
Why was this change needed? (You can also link to an open issue here)
Issue 🐛 Bug Report: Profile Settings Modal has no feedback for user data loading state #177
When the user opens the settings modal they have no indications about the data being loaded
When the user saves their changes, again there is no feedback for the user that the form is getting submitted which might cause them to hit the save button again and again.
When the profile details are loading the user can still hit the save button without noticing anything, so hence that is disabled now as well till the loading is done
Other information:
I saw Mantine as a dependency but I don't think it is being used anywhere in the whole project. Why are we not leveraging it, any specific reasons?