Add opt-out option for email notifications in user settings (#163) #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arafat4693 is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
nevo-david
reviewed
May 26, 2024
There was a problem hiding this comment.
Hi @arafat4693, thank you so much!
Left you some comments :)
| ) { | ||
| return this._organizationService.deleteTeamMember(org, id); | ||
| } | ||
|
|
||
| @Get('/email-notifications/:userId') |
There was a problem hiding this comment.
This is a bit dangerous because the userId can be faked. You should use the same technic in other routes
@GetUserFromRequest() user: User| return this._usersService.getEmailNotifications(userId); | ||
| } | ||
|
|
||
| @Post('/email-notifications/:userId') |
| const newSetting = !isChecked; | ||
| setIsChecked(newSetting); | ||
|
|
||
| await fetch(`/settings/email-notifications/${user.id}`, { |
There was a problem hiding this comment.
There is no need to pass the user.id, we have the authenticated user
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import { useVariables } from '@gitroom/react/helpers/variable.context'; | ||
|
|
||
| const general = isGeneral(); |
Check warning
Code scanning / ESLint
Disallow unused variables Warning
|
@arafat4693 , are you still interested in this PR? |
1 task
|
This PR is done. Waiting for It to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
Fixes 🚀 Feature: Disable email notifications from settings #163
This PR introduces an opt-out option for email notifications in system settings. Users can now choose whether they want to receive transactional emails.