Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Feature : Created an infrastructure for sending emails with dif… #172

Closed
wants to merge 2 commits into from

Conversation

Deepankar20
Copy link

…ferent provider

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • feature

  • Why was this change needed? (You can also link to an open issue here)

  • Other information:

Copy link

vercel bot commented May 11, 2024

@Deepankar20 is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@nevo-david
Copy link
Contributor

Super cool, @Deepankar20; my main problem is that you are using @Injectable, but you are creating a new instance instead of using dependency injections.

This is a bit problematic if want want to inject external services in the future!

@Deepankar20
Copy link
Author

sorry for the overlooking of @Injectable so i am thinking of changing code a little bit on emailprovider class would work where i dont create new instances instead i use closures. @nevo-david guide me if i am thinking right.

@nevo-david
Copy link
Contributor

Yes, let's use dependency injection. We will determine that using an env variable called EMAIL_PROVIDER.
Instead we can use class providers:
https://docs.nestjs.com/fundamentals/custom-providers

@nevo-david
Copy link
Contributor

Hi @Deepankar20 :)
Just following up on this

@Deepankar20
Copy link
Author

@nevo-david actually i was busy on my personal project and now learning more about nest so i can contribute more to gitroom!
:)

@Deepankar20
Copy link
Author

hey @nevo-david i have used dependency injection now , tell me if i am missing something.

@Deepankar20
Copy link
Author

hi @nevo-david wanted to ask about the pull request i created.

@Deepankar20
Copy link
Author

@nevo-david any updates?

@jamesread
Copy link
Collaborator

@Deepankar20 , sorry that nobody get back to you here. Would you be willing to fix the merge conflicts and I'll ping Nevo to re-review?

@jamesread
Copy link
Collaborator

Postiz recently added support for email providers, including nodemailer, which just allows for an email provider that supports SMTP. Closing this as there's been no activity in a month, and the code has been superseeded.

@jamesread jamesread closed this Oct 9, 2024
@Deepankar20 Deepankar20 deleted the feature/new-feature branch October 19, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants