-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Feature : Created an infrastructure for sending emails with dif… #172
Conversation
@Deepankar20 is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
Super cool, @Deepankar20; my main problem is that you are using @Injectable, but you are creating a new instance instead of using dependency injections. This is a bit problematic if want want to inject external services in the future! |
sorry for the overlooking of @Injectable so i am thinking of changing code a little bit on emailprovider class would work where i dont create new instances instead i use closures. @nevo-david guide me if i am thinking right. |
Yes, let's use dependency injection. We will determine that using an env variable called EMAIL_PROVIDER. |
Hi @Deepankar20 :) |
@nevo-david actually i was busy on my personal project and now learning more about nest so i can contribute more to gitroom! |
hey @nevo-david i have used dependency injection now , tell me if i am missing something. |
hi @nevo-david wanted to ask about the pull request i created. |
@nevo-david any updates? |
@Deepankar20 , sorry that nobody get back to you here. Would you be willing to fix the merge conflicts and I'll ping Nevo to re-review? |
Postiz recently added support for email providers, including nodemailer, which just allows for an email provider that supports SMTP. Closing this as there's been no activity in a month, and the code has been superseeded. |
…ferent provider
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
Why was this change needed? (You can also link to an open issue here)
Other information: