Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using a monochrome icon for Menu Bar Workspaces #73

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Nov 23, 2023

This PR makes it possible to use a monochrome icon for Menu Bar Workspaces. It also uses the monochrome icon as the default to blend in more with the standard MacOS experience.

A few screenshots:

Screenshot 2023-11-23 at 11 49 08
Screenshot 2023-11-23 at 11 49 14

@mads-hartmann mads-hartmann changed the title Add support for using a monochrome icon for the workspaces menubar Add support for using a monochrome icon for Menu Bar Workspaces Nov 23, 2023
@mads-hartmann
Copy link
Contributor Author

@Palanikannan1437 and @henit-chobisa I added support for configuring the icon style to preserve the orange color for people who prefer that. But I wanted to ask how you feel about not having it be configurable. The GitHub and Linear extensions don't make it configurable and they use monochrome by default ☺️

@Palanikannan1437
Copy link
Collaborator

@Palanikannan1437 and @henit-chobisa I added support for configuring the icon style to preserve the orange color for people who prefer that. But I wanted to ask how you feel about not having it be configurable. The GitHub and Linear extensions don't make it configurable and they use monochrome by default ☺️

I always liked the Gitpod orange differentiator in my menu bar, but for many it makes sense to go MacOS standards ie monochrome. So best choice moving forward seems to be keeping it configurable, thank you so much for this and taking the time for putting thoughts into this ✌️

Also, the GitHub notifications menubar Raycast extension command actually turns Golden if you have unread notifications....so could think of something in that direction too 🙂

@mads-hartmann mads-hartmann marked this pull request as ready for review November 24, 2023 09:06
@mads-hartmann
Copy link
Contributor Author

@Palanikannan1437 Awesome, I moved the PR out of draft so feel free to review it. I also added screenshots showing what it looks like in monochrome ☺️ @gtsiolis opened #74 which should fix some padding with the icon but the PRs can be merged/review independently.

@mads-hartmann
Copy link
Contributor Author

@Palanikannan1437 Okay, turns out it won't switch colours today when I "Toggle System Appearance" so moving back to draft 😝 Will see if I can figure out what's going on later

@mads-hartmann mads-hartmann marked this pull request as draft November 24, 2023 09:26
@mads-hartmann mads-hartmann deleted the mads/use-gitpod-url-from-preferences-everywhere branch November 24, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants