Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Run the toxic-config component as a sidecar in the Toxiproxy pod #14488

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

As part of #9198 we will run a Toxiproxy instance in the application cluster to allow us to simulate a high-latency connection to the Gitpod database.

#14473 added a new component, toxic-config, intended to run as a sidecar container in a Kubernetes pod alongside Toxiproxy, that configures a given proxy with a latency toxic.

This PR makes that new component run as a sidecar in the Toxiproxy component to ensure that the mysql component is configured with latency.

Related Issue(s)

Part of #9198

How to test

  1. Port forward to Toxiproxy:
kubectl port-forward svc/toxiproxy 8474:8474
  1. Verify that the sidecar container successfully configured the mysql proxy:
kubcectl logs deploy/toxiproxy -c toxic-config
  1. Verify that the mysql proxy has been configured with a latency toxic:
docker run --rm --net=host --entrypoint="/toxiproxy-cli" -it ghcr.io/shopify/toxiproxy inspect mysql

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-slow-database
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@andrew-farries
Copy link
Contributor Author

This PR was previously merged into the dependent branch as #14487 before I had a chance to add a hold label.

Base automatically changed from af/add-toxic-config-component to main November 8, 2022 15:43
@roboquat roboquat added size/L and removed size/S labels Nov 8, 2022
Andrew Farries added 3 commits November 8, 2022 16:04
Run the `toxic-config` component as sidecar container alongside
Toxiproxy to configure the Toxiproxy instance with a latency toxic.
@andrew-farries andrew-farries force-pushed the af/run-toxic-config-sidecar branch from 5dec20b to 3e5bd92 Compare November 8, 2022 16:04
@roboquat roboquat added size/S and removed size/L labels Nov 8, 2022
Copy link
Contributor

@felladrin felladrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes don't affect IDE components.

@roboquat roboquat merged commit 01b4ceb into main Nov 11, 2022
@roboquat roboquat deleted the af/run-toxic-config-sidecar branch November 11, 2022 09:38
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: IDE team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants