This repository has been archived by the owner on Apr 14, 2024. It is now read-only.
uses helm with raw yaml to deploy #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csantanapr
suggested changes
Sep 14, 2023
main.tf
Outdated
| yaml_body = each.value | ||
| name = each.key | ||
| namespace = "argocd" | ||
| repository = "https://bedag.github.io/helm-charts/" |
There was a problem hiding this comment.
I don't know who owns this chart.
Can we copy the helm chart to a local directory and use the helm chart from directory instead of relying on this 3rd chart and also network access to the domain bedag.github.io
There was a problem hiding this comment.
Good point the chart is pretty basic I’ll add a local copy
|
I've added the charts locally, works fine |
csantanapr
suggested changes
Sep 18, 2023
|
|
||
| */}} | ||
| {{- if or $.Values.resources $.Values.templates -}} | ||
| {{- $base := fromYaml (include "raw.labels" .) -}} |
There was a problem hiding this comment.
Lets try to eliminate the need to include the library chart, is just for common labels.
Lets implement the commonLabels in this chart and remove the library, or delete this line and remove support for "commonLabels" for now
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4
With this Terraform will only create a helm release, and helm will install manifests inside Kubernetes.
On next terraform apply, as the helm release already exists, there will be no updates.
To force Terraform recreate the helm release, it will need to be manually deleted in Kubernetes and reapply from terraform.
This is tested and seems very more reliable than the previous solution