Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme tweak to push deployments to master #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

readme tweak to push deployments to master #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,17 @@ At this point, the React app's `package.json` file includes a property named `ho
"start": "react-scripts start",
"build": "react-scripts build",
```
> \* To deploy code from `master` change the following settings in your package.json
```diff
"scripts": {
- "deploy": "gh-pages -d build",
+ "deploy": "gh-pages -b master -d build",
```
> \* Check settings in Github (Repo -> Settings -> Pages)
- **Source** in **Build and deployment** should be ***Deploy from a Branch***
- **Branch** should be selected to `master`
- **Folder** `/ (root)`
- After this follow the remaining instructions provided below **excluding point # 8**

At this point, the React app's `package.json` file includes deployment scripts.

Expand Down Expand Up @@ -204,7 +215,7 @@ At this point, the GitHub repository contains a branch named `gh-pages`, which c
1. In the sidebar, in the "Code and automation" section, click on "Pages"
1. Configure the "Build and deployment" settings like this:
1. **Source**: Deploy from a branch
2. **Branch**:
2. **Branch**:
- Branch: `gh-pages`
- Folder: `/ (root)`
1. Click on the "Save" button
Expand Down Expand Up @@ -293,4 +304,4 @@ Note: I specified the avatars using HTML because, when I did so using Markdown,
<img src="https://github.com/jackweyhrich.png?size=40" height="40" width="40" alt="jackweyhrich" />
</a>

This list is maintained manually—for now—and includes (a) each person who submitted a pull request that was eventually merged into `master`, and (b) each person who contributed in a different way (e.g. providing constructive feedback) and who approved of me including them in this list.
This list is maintained manually—for now—and includes (a) each person who submitted a pull request that was eventually merged into `master`, and (b) each person who contributed in a different way (e.g. providing constructive feedback) and who approved of me including them in this list.