Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RepositoryApi.compare(Object projectIdOrPath, String from, String to, Object fromProjectId, boolean straight) #1208

Merged
merged 12 commits into from
Dec 24, 2024

Conversation

otary
Copy link
Contributor

@otary otary commented Dec 10, 2024

add RepositoryApi.compare(Object projectIdOrPath, String from, String to, Object fromProjectId, boolean straight)

@@ -914,18 +914,7 @@ public File getRepositoryArchive(
*/
public CompareResults compare(Object projectIdOrPath, String from, String to, boolean straight)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this method should be deprecated, now that we have the one accepting more parameters.

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look almost good to me. Thank you for this contribution.

@jmini jmini merged commit 569c51c into gitlab4j:main Dec 24, 2024
2 checks passed
@jmini
Copy link
Collaborator

jmini commented Dec 24, 2024

🎉 thank you for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants