Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group api parameters #1073

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Add group api parameters #1073

merged 3 commits into from
Dec 27, 2023

Conversation

simon-weimann
Copy link
Contributor

  • adds protected_against_pushes and full_protection_after_initial_push branch protection level
  • adds prevent_sharing_groups_outside_of_hierarchy
  • adds prevent_forking_outside_group

@simon-weimann
add group api parameters
804c264 
- adds protected_against_pushes and full_protection_after_initial_push
  branch protection level
- adds prevent_sharing_groups_outside_of_hierarchy
- adds prevent_forking_outside_group
@jmini
Copy link
Collaborator

jmini commented Dec 20, 2023

Documentation:

jmini
jmini requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that those flags are also part of the response returned on group update or create.

So we should add those in Group and update the group.json as well.

@simon-weimann
extend groupApi to return more details
c7fcd88 
- default_branch_protection
- subgroup_creation_level
- project_creation_level
- prevent_forking_outside_group
- prevent_sharing_groups_outside_hierarchy
@simon-weimann
Copy link
Contributor Author

simon-weimann commented Dec 22, 2023 •
edited
Loading

Hi @jmini,

thanks for the feedback. I have incorporated the requested changes.

The failing tests seem to be broken on the main branch see https://github.com/gitlab4j/gitlab4j-api/actions/runs/7297607949/job/19887139845

@simon-weimann simon-weimann requested a review from jmini December 22, 2023 12:54
@jmini
Copy link
Collaborator

jmini commented Dec 27, 2023

Sorry about the failing tests on the main branch.
I made a mistake with a merge-request that I merged only partially.
This was fixed yesterday.

I have now pushed origin/main into your branch.

jmini
jmini approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will perform some tests and merge

jmini added a commit to jmini/gitlab-experiments that referenced this pull request Dec 27, 2023
@jmini
GroupScript update gitlab4j version
a02fb81 
Test for PR gitlab4j/gitlab4j-api#1073
@jmini jmini merged commit 6a89da0 into gitlab4j:main Dec 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmini jmini jmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon-weimann @jmini