Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new api call for forced push checks #1071 #1072

Merged
merged 5 commits into from
Dec 26, 2023
Merged

Conversation

dpalic
Copy link
Contributor

@dpalic dpalic commented Dec 19, 2023

Here a change to expose the forced commit check

Gitlab documentation: https://docs.gitlab.com/ee/api/protected_branches.html

Fixes #1071

@dpalic
Copy link
Contributor Author

dpalic commented Dec 19, 2023

with the new 6.0 release the api change may be okay, since everyone expects to do minor changes on major version change

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but the changes described in the comments are needed

@dpalic
Copy link
Contributor Author

dpalic commented Dec 25, 2023

changed the reported issues, would be great if you could check and merge into master for next major release

@dpalic dpalic requested a review from jmini December 26, 2023 10:19
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some additional changes.
I will perform some manual tests and merge

jmini added a commit to jmini/gitlab-experiments that referenced this pull request Dec 26, 2023
@jmini jmini merged commit ddb244e into gitlab4j:main Dec 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProtectedBranch contains allowForcePush, but cannot persist it
2 participants