Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add reopenIssue api in IssuesApi #1042 #1043

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat: add reopenIssue api in IssuesApi #1042 #1043

merged 1 commit into from
Nov 6, 2023

Conversation

neilwangweili
Copy link
Contributor

@neilwangweili neilwangweili commented Oct 12, 2023

Fixes: #1042

@neilwangweili neilwangweili changed the title feat: add reopenIssue api in IssuesApi feat: add reopenIssue api in IssuesApi #1042 Oct 12, 2023
@jmini
Copy link
Collaborator

jmini commented Oct 20, 2023

I agree that this addition is consistent with the other methods provided in the API.

With other endpoints we have only one update method which accepts a EntityUpdateParam or directly the Entity and call the update method, but this is not the case for the issue update endpoint.

jmini added a commit to jmini/gitlab-experiments that referenced this pull request Nov 6, 2023
@jmini jmini merged commit 0c4c5c5 into gitlab4j:main Nov 6, 2023
1 check passed
@jmini
Copy link
Collaborator

jmini commented Nov 6, 2023

Thank you very much for this contribution 🎉

@neilwangweili neilwangweili deleted the patch-1 branch November 6, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design alias reopenIssue for updateIssue(..., Constants.StateEvent.REOPEN, ...)
2 participants