Smell SimplifiedTernary solved

gitlab4j · Nov 15, 2023 · abebd49 · abebd49
1 parent bfe15f6
commit abebd49
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/java/org/gitlab4j/api/HookManager.java b/src/main/java/org/gitlab4j/api/HookManager.java
@@ -33,8 +33,8 @@ public interface HookManager {
     default public boolean isValidSecretToken(String secretToken) {
         String ourSecretToken = getSecretToken();
         return (ourSecretToken == null ||
-                ourSecretToken.trim().isEmpty() ||
-                ourSecretToken.equals(secretToken) ? true : false);
+            ourSecretToken.trim().isEmpty() ||
+            ourSecretToken.equals(secretToken));
     }
 
     /**

diff --git a/src/main/java/org/gitlab4j/api/utils/EmailChecker.java b/src/main/java/org/gitlab4j/api/utils/EmailChecker.java
@@ -22,6 +22,10 @@ public class EmailChecker {
      * @return true if the provided String is a valid email address, otherwise return false
      */
      public static final boolean isValidEmail(final String email) {
-         return (email == null ? false : EMAIL_REGEX_PATTERN.matcher(email).matches());
+        if (email == null) {
+            return false;
+        } else {
+            return EMAIL_REGEX_PATTERN.matcher(email).matches();
+        }
     }
 }