Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Unsubscribe from repository" button #784

Closed
wants to merge 4 commits into from

Conversation

adufr
Copy link
Contributor

@adufr adufr commented Feb 18, 2024

Context

Add a "Unsubscribe from repository" button.
image

It uses the "Set a repository subscription" REST API,

Discussion

Two things:

  • At first I was going to start implementing the "Mark repository as done" button (as it had already been discussed in feat: add a "mark notification as done" button #706, PR coming soon 😉), but having miss-aligned icons made me look into adding this feature first...
    But I feel like it's really "heavy" on the UI, it's not so beautiful and it makes it harder to distinguish if the row is a Notification or a Repository...
    What do you think?

  • Following the "Unsubscribe from notification" implementation, I made it so that clicking on Repository unsubscribe marks all of the repository's notifications as read. But this behaviour looks a bit odd to me; why automatically discard all those notifications? And why mark them as read instead of done? Perhaps it is better not to discard those notifications at all? If so, we would have to find a way to tell the user that the unsubscribe action has been successful...

@adufr
Copy link
Contributor Author

adufr commented Feb 18, 2024

TBH even though this feature could still be a nice to have; I'm not sure it's required.
Maybe the solution to the misalignment of the icons between Repository and NotificationRow could just be a space between the Mark repository as done and Mark Repository as read buttons:
image

Please tell me what you think so I can adjust my PRs :P

@bmulholland
Copy link
Collaborator

I don't currently have mental space to wrap my head around everything in the description, but two thoughts that come to mind on a first pass:

  1. There's an added twist for this one: it could be taken to mean "unsubscribe from this repository," which isn't what this is doing.
  2. To solve the visual complexity of all these icons, we could show the icons only on hover. That would be discoverable (you naturally mouse over the items to open them).

@adufr
Copy link
Contributor Author

adufr commented Feb 19, 2024

There's an added twist for this one: it could be taken to mean "unsubscribe from this repository," which isn't what this is doing.

Yup, that's why I'm really not sure that it's a good idea to implement this 😬

To solve the visual complexity of all these icons, we could show the icons only on hover. That would be discoverable (you naturally mouse over the items to open them).

I thought about this too! If others agree with this we can try it?

@setchy
Copy link
Member

setchy commented Feb 23, 2024

I like the idea of exploring showing the 3-notification buttons on mouse-over the row, which is similar to how GitHub behaves.

Re: unsubscribe from repository, i'm not sure this is needed. GitHub when viewing notifications grouped-by repo only has the mark as read button

@adufr
Copy link
Contributor Author

adufr commented Feb 24, 2024

I'm dropping this PR, I've been running a main build for a few days and the repository "done" button looks enough

@adufr adufr closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants