-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: move lint into separate workflow #1246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, why exactly?
Explicit check feedback |
Isn't looking at the workflow failure reason not enough? 😅 |
I think it's more intuitive if it is a separate step, whether that's a separate workflow file (lint.yml) or the same (test.yml). We have this clarity already in Build App and Release App and Validators 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not :D
IMHO this is best practice :) |
No description provided.