Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort tw classes #1233

Merged
merged 6 commits into from
Jun 13, 2024
Merged

chore: sort tw classes #1233

merged 6 commits into from
Jun 13, 2024

Conversation

afonsojramos
Copy link
Member

Also managed to find some incorrect tailwind classes 👀 (such as text-capitalize)

@afonsojramos afonsojramos added the bug Something isn't working label Jun 13, 2024
@setchy
Copy link
Member

setchy commented Jun 13, 2024

nice! what magic did you use to sort the classes? how do we maintain this ongoing?

@afonsojramos afonsojramos force-pushed the feat/notification-removal-animation branch from 1032de1 to 4053f86 Compare June 13, 2024 15:49
@afonsojramos
Copy link
Member Author

We're on our own regarding detection of inexistent classes. Regarding sorting, it doesn't really make THAT much of a difference, but it does on some things.

Biome doesn't support this yet (being tracked here: biomejs/biome#1274), but with prettier you can already have this with https://github.com/tailwindlabs/prettier-plugin-tailwindcss.

Tbh, I ran it because I found text-capitalize, otherwise I'd probably leave it be. Because once you sort, non-tailwind classes get pushed to the front, making them easier to see, but it still doesn't solve the issue.

@afonsojramos
Copy link
Member Author

@setchy check this comment I just left regarding that 👀

Base automatically changed from feat/notification-removal-animation to main June 13, 2024 16:02
@setchy setchy merged commit be44194 into main Jun 13, 2024
7 checks passed
@setchy setchy deleted the chore/sort-tailwind-classes branch June 13, 2024 16:44
@setchy setchy modified the milestones: Release 5.9.0, Release 5.8.1 Jun 13, 2024
@afonsojramos
Copy link
Member Author

Was a bit all over the place today and forgot to post the link 🤦

biomejs/biome#1274 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants