Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate react-transition-group over tailwind animations #1232

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

afonsojramos
Copy link
Member

Resolves #1071.

@afonsojramos afonsojramos added the refactor Refactoring of existing feature label Jun 13, 2024
@afonsojramos afonsojramos added this to the Release 5.9.0 milestone Jun 13, 2024
package.json Outdated Show resolved Hide resolved
Copy link
Member

@setchy setchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! so we can continue using tailwind for transitions

@afonsojramos afonsojramos changed the title feat: use clsx to merge classNames refactor: deprecate react-transition-group over tailwind animations Jun 13, 2024
@afonsojramos afonsojramos changed the base branch from main to feat/cn June 13, 2024 15:41
@afonsojramos
Copy link
Member Author

Sorry, just changed base! Was doing multiple things at once.

@afonsojramos afonsojramos force-pushed the feat/notification-removal-animation branch from 1032de1 to 4053f86 Compare June 13, 2024 15:49
@afonsojramos afonsojramos requested a review from setchy June 13, 2024 15:50
Base automatically changed from feat/cn to main June 13, 2024 15:51
@afonsojramos afonsojramos merged commit f360e16 into main Jun 13, 2024
6 checks passed
@afonsojramos afonsojramos deleted the feat/notification-removal-animation branch June 13, 2024 16:02
@setchy setchy modified the milestones: Release 5.9.0, Release 5.8.1 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace react-transition-group animations with maintained alternative
2 participants