Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release): remove gh_token env #1213

Merged
merged 2 commits into from
Jun 10, 2024
Merged

build(release): remove gh_token env #1213

merged 2 commits into from
Jun 10, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 9, 2024

use default auto provisioned GitHub actions token instead of my custom PAT

remove gh_token env variable. should use github_token

use default auto provisioned GitHub actions token instead of a custom PAT
@setchy setchy added the build Build, action or package manager changes label Jun 9, 2024
@setchy setchy added this to the Release 5.8.0 milestone Jun 9, 2024
@setchy setchy changed the title build: use default GitHub actionstoken build: use default GitHub actions token Jun 10, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default default GitHub actions token, afaik doesn't need to be provided at all, so we can just delete it I think!

@setchy
Copy link
Member Author

setchy commented Jun 10, 2024

The default default GitHub actions token, afaik doesn't need to be provided at all, so we can just delete it I think!

even better. i was trying to recall when this got added. i think it was during our notorization dark days haha

@setchy
Copy link
Member Author

setchy commented Jun 10, 2024

looking again, i think it's needed so that it's passed as process.env. to electron builder

@setchy
Copy link
Member Author

setchy commented Jun 10, 2024

i take it back :p https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

let's give it a shot. worst case we add it back in when we do v5.8.0 release :)

removed in new commit

@setchy setchy changed the title build: use default GitHub actions token build(release): remove gh_token env Jun 10, 2024
@setchy setchy requested a review from afonsojramos June 10, 2024 16:49
@afonsojramos afonsojramos merged commit 9568069 into main Jun 10, 2024
11 checks passed
@afonsojramos afonsojramos deleted the setchy-patch-1 branch June 10, 2024 16:51
@setchy
Copy link
Member Author

setchy commented Jun 13, 2024

no dice - had to revert this for the 5.8.0 release...

without specifying GITHUB_TOKEN or GH_TOKEN, electron-builder doesn't work.

using the default GITHUB_TOKEN doesn't have enough permissions to upload artifacts to the release notes.

Will continue using my GH_TOKEN for now. Ideally we'd create this within the gitify-app org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, action or package manager changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants