-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(release): remove gh_token env #1213
Conversation
use default auto provisioned GitHub actions token instead of a custom PAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default default GitHub actions token, afaik doesn't need to be provided at all, so we can just delete it I think!
even better. i was trying to recall when this got added. i think it was during our notorization dark days haha |
looking again, i think it's needed so that it's passed as |
i take it back :p https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow let's give it a shot. worst case we add it back in when we do v5.8.0 release :) removed in new commit |
no dice - had to revert this for the 5.8.0 release... without specifying using the default Will continue using my |
use default auto provisioned GitHub actions token instead of my custom PATremove gh_token env variable. should use
github_token