refactor: update sidebar labels (#1538)

Signed-off-by: Adam Setch <[email protected]>
gitify-app · Sep 18, 2024 · 32c7118 · 32c7118
1 parent acab7c7
commit 32c7118
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 41 deletions.
diff --git a/src/components/Sidebar.test.tsx b/src/components/Sidebar.test.tsx
@@ -98,13 +98,13 @@ describe('components/Sidebar.tsx', () => {
           </AppContext.Provider>,
         );
 
-        const notificationsIcon = screen.getByTitle('0 Unread Notifications');
+        const notificationsIcon = screen.getByTitle('0 unread notifications');
 
         expect(notificationsIcon.className).toContain('text-white');
         expect(notificationsIcon.childNodes.length).toBe(1);
         expect(notificationsIcon.childNodes[0].nodeName).toBe('svg');
 
-        fireEvent.click(screen.getByLabelText('0 Unread Notifications'));
+        fireEvent.click(screen.getByLabelText('0 unread notifications'));
 
         expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
         expect(openExternalLinkMock).toHaveBeenCalledWith(
@@ -128,14 +128,14 @@ describe('components/Sidebar.tsx', () => {
           </AppContext.Provider>,
         );
 
-        const notificationsIcon = screen.getByTitle('4 Unread Notifications');
+        const notificationsIcon = screen.getByTitle('4 unread notifications');
 
         expect(notificationsIcon.className).toContain(IconColor.GREEN);
         expect(notificationsIcon.childNodes.length).toBe(2);
         expect(notificationsIcon.childNodes[0].nodeName).toBe('svg');
         expect(notificationsIcon.childNodes[1].nodeValue).toBe('4');
 
-        fireEvent.click(screen.getByLabelText('4 Unread Notifications'));
+        fireEvent.click(screen.getByLabelText('4 unread notifications'));
 
         expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
         expect(openExternalLinkMock).toHaveBeenCalledWith(
@@ -161,7 +161,7 @@ describe('components/Sidebar.tsx', () => {
       </AppContext.Provider>,
     );
 
-    fireEvent.click(screen.getByLabelText('My Issues'));
+    fireEvent.click(screen.getByLabelText('My issues'));
 
     expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
     expect(openExternalLinkMock).toHaveBeenCalledWith(
@@ -185,7 +185,7 @@ describe('components/Sidebar.tsx', () => {
       </AppContext.Provider>,
     );
 
-    fireEvent.click(screen.getByLabelText('My Pull Requests'));
+    fireEvent.click(screen.getByLabelText('My pull requests'));
 
     expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
     expect(openExternalLinkMock).toHaveBeenCalledWith(
@@ -212,7 +212,7 @@ describe('components/Sidebar.tsx', () => {
         </AppContext.Provider>,
       );
 
-      fireEvent.click(screen.getByTitle('Refresh Notifications'));
+      fireEvent.click(screen.getByTitle('Refresh notifications'));
 
       expect(fetchNotifications).toHaveBeenCalledTimes(1);
     });
@@ -235,7 +235,7 @@ describe('components/Sidebar.tsx', () => {
         </AppContext.Provider>,
       );
 
-      fireEvent.click(screen.getByTitle('Refresh Notifications'));
+      fireEvent.click(screen.getByTitle('Refresh notifications'));
 
       expect(fetchNotifications).not.toHaveBeenCalled();
     });
@@ -344,7 +344,7 @@ describe('components/Sidebar.tsx', () => {
         </MemoryRouter>
       </AppContext.Provider>,
     );
-    fireEvent.click(screen.getByLabelText('4 Unread Notifications'));
+    fireEvent.click(screen.getByLabelText('4 unread notifications'));
     expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
     expect(openExternalLinkMock).toHaveBeenCalledWith(
       'https://github.com/notifications',
@@ -368,7 +368,7 @@ describe('components/Sidebar.tsx', () => {
         </MemoryRouter>
       </AppContext.Provider>,
     );
-    fireEvent.click(screen.getByLabelText('My Issues'));
+    fireEvent.click(screen.getByLabelText('My issues'));
     expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
     expect(openExternalLinkMock).toHaveBeenCalledWith(
       'https://github.com/issues',
@@ -392,7 +392,7 @@ describe('components/Sidebar.tsx', () => {
         </MemoryRouter>
       </AppContext.Provider>,
     );
-    fireEvent.click(screen.getByLabelText('My Pull Requests'));
+    fireEvent.click(screen.getByLabelText('My pull requests'));
     expect(openExternalLinkMock).toHaveBeenCalledTimes(1);
     expect(openExternalLinkMock).toHaveBeenCalledWith(
       'https://github.com/pulls',
@@ -439,7 +439,7 @@ describe('components/Sidebar.tsx', () => {
         </AppContext.Provider>,
       );
 
-      const notificationsIcon = screen.getByTitle('0 Unread Notifications');
+      const notificationsIcon = screen.getByTitle('0 unread notifications');
       expect(notificationsIcon.className).toContain('text-white');
       expect(notificationsIcon.childNodes.length).toBe(1);
       expect(notificationsIcon.childNodes[0].nodeName).toBe('svg');
@@ -461,7 +461,7 @@ describe('components/Sidebar.tsx', () => {
         </AppContext.Provider>,
       );
 
-      const notificationsIcon = screen.getByTitle('4 Unread Notifications');
+      const notificationsIcon = screen.getByTitle('4 unread notifications');
       expect(notificationsIcon.className).toContain(IconColor.GREEN);
       expect(notificationsIcon.childNodes.length).toBe(2);
       expect(notificationsIcon.childNodes[0].nodeName).toBe('svg');

diff --git a/src/components/Sidebar.tsx b/src/components/Sidebar.tsx
@@ -83,20 +83,20 @@ export const Sidebar: FC = () => {
         </button>
 
         <SidebarButton
-          title={`${notificationsCount} Unread Notifications`}
+          title={`${notificationsCount} unread notifications`}
           metric={isLoggedIn ? notificationsCount : null}
           icon={BellIcon}
           onClick={() => openGitHubNotifications(primaryAccountHostname)}
         />
 
         <SidebarButton
-          title="My Issues"
+          title="My issues"
           icon={IssueOpenedIcon}
           onClick={() => openGitHubIssues(primaryAccountHostname)}
         />
 
         <SidebarButton
-          title="My Pull Requests"
+          title="My pull requests"
           icon={GitPullRequestIcon}
           onClick={() => openGitHubPulls(primaryAccountHostname)}
         />
@@ -106,7 +106,7 @@ export const Sidebar: FC = () => {
         {isLoggedIn && (
           <>
             <SidebarButton
-              title="Refresh Notifications"
+              title="Refresh notifications"
               icon={SyncIcon}
               size={Size.MEDIUM}
               loading={status === 'loading'}

diff --git a/src/components/__snapshots__/Sidebar.test.tsx.snap b/src/components/__snapshots__/Sidebar.test.tsx.snap