Skip to content

Commit

Permalink
fix: overflow ellipsis (#1375)
Browse files Browse the repository at this point in the history
  • Loading branch information
setchy authored Jul 15, 2024
1 parent c8f44f2 commit 067d154
Show file tree
Hide file tree
Showing 5 changed files with 70 additions and 30 deletions.
4 changes: 2 additions & 2 deletions src/components/NotificationRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const NotificationRow: FC<INotificationRow> = ({
</div>

<div
className="flex-1 overflow-hidden overflow-ellipsis whitespace-nowrap cursor-pointer"
className="flex-1 truncate cursor-pointer"
onClick={() => handleNotification()}
>
<NotificationHeader notification={notification} />
Expand All @@ -111,7 +111,7 @@ export const NotificationRow: FC<INotificationRow> = ({
role="main"
title={notificationTitle}
>
{notification.subject.title}
<span className="truncate">{notification.subject.title}</span>
<span
className={cn(
'text-xxs',
Expand Down
2 changes: 1 addition & 1 deletion src/components/RepositoryNotifications.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export const RepositoryNotifications: FC<IRepositoryNotifications> = ({
>
<div
className={cn(
'flex flex-1 gap-4 items-center overflow-hidden overflow-ellipsis whitespace-nowrap text-sm font-medium',
'flex flex-1 gap-4 items-center truncate text-sm font-medium',
Opacity.MEDIUM,
)}
>
Expand Down
32 changes: 24 additions & 8 deletions src/components/__snapshots__/AccountNotifications.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

48 changes: 36 additions & 12 deletions src/components/__snapshots__/NotificationRow.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 067d154

Please sign in to comment.