Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always enable both TS & TSX in CLI #433

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

hendrikvanantwerpen
Copy link
Collaborator

The tree-sitter-stack-graphs-typescript CLI accepts a flag to switch between TS and TSX.

This is not quite the right design because (a) TS and TSX files often occur in mixed code bases, and (b) we can determine the dialect from the file extension anyway.

This PR changes the CLI to always have both dialects enabled.

Fixes #431.

@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner May 15, 2024 10:09
@hendrikvanantwerpen hendrikvanantwerpen self-assigned this May 15, 2024
@shirelga
Copy link

Thanks!

@shirelga
Copy link

shirelga commented May 15, 2024

@hendrikvanantwerpen
I have ran it locally, it parsed and index both .tsx|.ts. 🙏

@hendrikvanantwerpen hendrikvanantwerpen merged commit ea70811 into main May 15, 2024
8 checks passed
@hendrikvanantwerpen hendrikvanantwerpen deleted the add-tsx-to-cli branch May 15, 2024 13:05
@github github deleted a comment from Savagebeast0 May 16, 2024
@github github deleted a comment from Savagebeast0 May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index/Parse does not support .tsx files
3 participants