Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Extraneous New Expr Edges #363

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

BekaValentine
Copy link
Contributor

This PR removes extraneous edges in the graphs for new_expression. This was causing a bug in the VEA Living Spec test case https://github.com/github/living-spec-vea/tree/main/vulnerabilities_in_class_definition. Once this PR is merged, that test should pass as expected.

BekaValentine and others added 2 commits December 18, 2023 12:08
Co-Authored-By: Rob Rix <[email protected]>
Copy link
Collaborator

@hendrikvanantwerpen hendrikvanantwerpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BekaValentine BekaValentine merged commit 699400f into main Dec 19, 2023
6 checks passed
@BekaValentine BekaValentine deleted the extraneous_new_expr_edges branch December 19, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants