Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More visualization changes #344

Merged
merged 2 commits into from
Nov 9, 2023
Merged

More visualization changes #344

merged 2 commits into from
Nov 9, 2023

Conversation

hendrikvanantwerpen
Copy link
Collaborator

@hendrikvanantwerpen hendrikvanantwerpen commented Nov 9, 2023

A few small improvements to the visualizaton:

  • Add file legend (can be toggeled by pressing f).

  • Make border of clickable nodes heavier. I tried @dcreager's suggestion to lighten non-clickable nodes compared to clickable (definition, reference) nodes. I found that this would make clickable nodes very light and the graph structure became harder to see. This change will hopefully make it still easier to find clickable nodes, even when zoomed out more.

Example

image

@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner November 9, 2023 17:39
@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Performance Summary

Comparing base 8ab4184 with head 1acebc7 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
9.150^                                             :##                        
     |                                             :#                     :   
     |                                             :#                     :   
     |                                             :#                     :   
     |                                             :# ::                  ::::
     |                                             :# :                   :: :
     |                :                          @ :# :                :  :: :
     |                :         :                @ :# :                :  :: :
     |                ::::      ::@              @::# :                ::::: :
     |                ::::      ::@              @::# :                :  :: :
     |               :::::     :::@            ::@::# :      :        ::  :: :
     |              @:::::   :::::@  :::       : @::# :     ::       :::  :: :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   90.38
After
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
9.150^                                             ::#                        
     |                                             : #                    ::  
     |                                             : #                    :   
     |                                             : #                    :   
     |                                             : #:                   : ::
     |                                             : #:                   : ::
     |                :@                        :@ : #:                   : ::
     |                :@        :               :@ : #:                   : ::
     |                :@::      :::             :@:: #:                 ::: ::
     |                :@::    : :::             :@:: #:                 : : ::
     |               ::@::    :::::            ::@:: #:      :        ::: : ::
     |              @::@::    :::::   :       :::@:: #: :   ::       @::: : ::
   0 +----------------------------------------------------------------------->Gi
     0                                                                   90.11

@hendrikvanantwerpen hendrikvanantwerpen merged commit 5aa2a6e into main Nov 9, 2023
10 checks passed
@hendrikvanantwerpen hendrikvanantwerpen deleted the file-viz branch November 9, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants