Port first batch of JS changes #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the first batch of JS changes from the old DSL to the new DSL. The Aleph commits covered are 233bbb017de91c387a3339d6f065a7c652b72ea3..266e33d910ff2c0d87b3e9235fef7231733ceafa.
Status
All tests pass now. Most were fixed by ensuring all changes were ported over. Two additional changes that were not part of the Aleph change set were necessary:
2849522 fixes some test failures that included the line number of an assigned value, even if that value was not a definition. I'm not sure why those were included in the first place, but I've removed those lines---keeping the lines for the actual definitions those values were assigned to.
d0754f7 fixes a test with default imports. The default guards were inconsistently references/definitions or plain push/pop nodes. Ensuring all default guards are treated as references/definitions fixed the failure. This seems the right thing, but was not part of the changes I was porting.