Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JavaScript #315

Merged
merged 205 commits into from
Oct 19, 2023
Merged

Add JavaScript #315

merged 205 commits into from
Oct 19, 2023

Conversation

hendrikvanantwerpen
Copy link
Collaborator

No description provided.

hendrikvanantwerpen and others added 23 commits October 12, 2023 13:31
Co-authored-by: Rebecca Valentine <[email protected]>
Elements that could be empty (i.e., not have subnodes) connected
their before and after scopes unconditionally. This could lead to
exponential blow ups when they were not empty: the direct pass
through and the path through the elements were equivalent.

Guarding the pass-through with a conditional that ensures it is
only created when there are indeed no sub nodes prevents this.
@hendrikvanantwerpen hendrikvanantwerpen marked this pull request as ready for review October 17, 2023 16:50
@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner October 17, 2023 16:50
@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Oct 19, 2023
@BekaValentine BekaValentine merged commit 16ee564 into main Oct 19, 2023
6 checks passed
@BekaValentine BekaValentine deleted the new_js branch October 19, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants