Empty (but not null) entries should clear teams and collaborators #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinm82
reviewed
Dec 8, 2022
| new NopCommand(this.constructor.name, this.repo, this.github.repos.removeCollaborator( | ||
| Object.assign(this.repo, { username: existing.username }) | ||
| ), 'Remove Collaborator') | ||
| new NopCommand(this.constructor.name, this.repo, this.github.repos.removeCollaborator(data), |
There was a problem hiding this comment.
Be careful. This will remove the collaborators. See https://github.com/github/safe-settings/pull/342/files#diff-aadaae6765a1167f3187e283961920c01d5db933ff8a7908ff10554b5520e689R117.
| @@ -28,19 +28,19 @@ module.exports = class Teams extends Diffable { | |||
|
|
|||
| add (attrs) { | |||
| let existing = { team_id: 1 } | |||
| this.log(`Getting team with the parms ${JSON.stringify(attrs)}`) | |||
| this.log.debug(`Getting team with the parms ${JSON.stringify(attrs)}`) | |||
There was a problem hiding this comment.
Suggested change
| this.log.debug(`Getting team with the parms ${JSON.stringify(attrs)}`) | |
| this.log.debug(`Getting team with the params ${JSON.stringify(attrs)}`) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This conflicts with my other PRs so I'm opening as a draft. Also this handles the case in diffable.js, but maybe
mergeDeep.compareDeepshould instead output removed entries directly?