Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases for superfluous days #263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

TymekDev
Copy link

This PR adds cases for whole years and whole months to not have extra days, e.g. May (2023-05-11T00:00:00.00) to July (2023-07-11T00:00:00.00) being 2 months instead of current 2 months, 1 day.

Related issue: #262

@TymekDev TymekDev requested a review from a team as a code owner July 11, 2023 20:53
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@lukasoppermann
Copy link

I'd love for @keithamus to approve this as he is working on it. Fine from primer FR side

@keithamus
Copy link
Member

Thanks, I'm looking into fixing this but I have higher priorities for now. A fix will come though!

@keithamus keithamus self-assigned this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants