Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadowed trustedroot #178

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fix shadowed trustedroot #178

merged 2 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. Fix shadowed variable bug 

    This code caused the singleton `trustedRoot` to be returned as nil on subsequent calls. The singleton was shadowed when the variable was redeclared in the `if` block.

Signed-off-by: Cody Soyland <[email protected]>
    @codysoyland
    codysoyland committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3720290 View commit details
    Browse the repository at this point in the history

  2. Remove unused singleton 

    `singletonRootError` was never returned without being overwritten, so it was essentially unused. I think it's wise to always retry the TUF call on future invocations in case of network errors.

Signed-off-by: Cody Soyland <[email protected]>
    @codysoyland
    codysoyland committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2b7dc34 View commit details
    Browse the repository at this point in the history