Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jekyll 3.10.0 #917

Closed
wants to merge 1 commit into from
Closed

Upgrade to Jekyll 3.10.0 #917

wants to merge 1 commit into from

Conversation

parkr
Copy link
Contributor

@parkr parkr commented Jun 24, 2024

No functionality is changed. Since Ruby 3.0 dropped webrick and Ruby 3.4 is going to drop csv, this adds them back as dependencies.

https://jekyllrb.com/news/2024/06/23/jekyll-3-10-0-released/

Fixes #899.
Fixes #887.
Fixes #864.
Fixes #752.

/cc @yoannchaudet

No functionality is changed. Since Ruby 3.0 dropped webrick and Ruby 3.4 is going to drop csv, this adds them back as dependencies.

https://jekyllrb.com/news/2024/06/23/jekyll-3-10-0-released/
@parkr
Copy link
Contributor Author

parkr commented Jun 24, 2024

I believe CI may have spotted this, a very outdated gemspec: https://github.com/github/jekyll-commonmark-ghpages/blob/510cdf1291ff6a76eb1341e7d5976bdcede41e47/jekyll-commonmark-ghpages.gemspec#L17

Looks like that could be loosened to v3.9 or greater.

@yoannchaudet
Copy link
Contributor

Checking on the commonmark side.

@yoannchaudet yoannchaudet mentioned this pull request Jul 18, 2024
@yoannchaudet
Copy link
Contributor

We shall be good now with #919.

Need to prep a release.

@parkr parkr deleted the patch-1 branch August 6, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment