Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ignore_users authored items from markdown results #379

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Sep 24, 2024

Pull Request

fixes #365

Proposed Changes

This pull request introduces three changes to remove issues and pull requests authored by ignored users. The three changes are

  1. updating the README.md to clarify the behavior of the IGNORE_USERS setting
  2. modifying the issue_metrics.py file to filter out issues from ignored users
  3. adding new tests to ensure the functionality works correctly

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@zkoppert zkoppert self-assigned this Sep 24, 2024
@github-actions github-actions bot added the fix label Sep 24, 2024
@zkoppert zkoppert marked this pull request as ready for review September 24, 2024 04:55
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Love the test coverage.

@jmeridth jmeridth merged commit 8cee549 into main Sep 24, 2024
31 checks passed
@jmeridth jmeridth deleted the ignored-users-in-report branch September 24, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore users still appear in the issue/pull request list in markdown
2 participants