Add Asset and Organization resources

[jeffgran-dox]

• Adds some new resources that are newer in the API.
• Updates StructuredScope to have the program id so that it can construct its URLs.

[rzhade3]

Thanks for the PR and the added functionality! I have a couple comments below about the implementation, mainly to ensure that calling/ method signatures are consistent across the library.

Are you able to write and record tests for this additional functionality? If you don't have access to a test HackerOne instance, I can help record VCR tests, but would you please mind writing some tests, similar to program_spec.rb and swag_spec.rb?

[rzhade3]

This should not be needed, as Ostruct is bundled with Ruby: https://github.com/ruby/ostruct?tab=readme-ov-file#installation.

I don't see anything inherently wrong with this, so fine with the diff but it in theory it shouldn't be breaking anything currently.

[jeffgran-dox]

I didn't need this when I was testing this locally but then when I tried to use it in another context it crashed with an "openstruct is not defined" error. I'm not sure what the cause was, maybe a different ruby version that doesn't require it by default any more or something. So I feel like it's worth leaving it in to prevent someone else from running into that, and like you say I think it should be harmless.

[rzhade3]

I've noted a change to the method signature above to accept program instead. Also, more idiomatically, can we just add a attr_reader :program above? This will match the implementation in places like

hackerone-client/lib/hackerone/client/incremental/activities.rb

Line 9 in cd44f29

attr_reader :program, :updated_at_after, :page_size

[rzhade3]

In keeping with the pattern that was set in the Swag object:

hackerone-client/lib/hackerone/client/swag.rb

Line 9 in cd44f29

def initialize(swag, program = nil)

Let's set this method signature to scope, program = nil. This will also allow this change to be backwards compatible.

Suggested change

	def initialize(program_id, scope)
	def initialize(scope, program = nil)

Here's another callsite that accepts program, for example:

hackerone-client/lib/hackerone/client/incremental/activities.rb

Lines 11 to 12 in cd44f29

	def initialize(program, updated_at_after: nil, page_size: 25)
	@program = program

[rzhade3]

Suggested change

	make_put_request("programs/#{@program_id}/structured_scopes/#{id}", request_body: body)
	make_put_request("programs/#{@program.id}/structured_scopes/#{id}", request_body: body)

[rzhade3]

The pattern in other objects of this library is currently object, additional_parameter:

Suggested change

	def initialize(organization_id, asset)
	def initialize(asset, organization)

[jeffgran-dox]

@rzhade3 thanks for the review! yes, I'll address your comments and work on adding some specs.

[jeffgran-dox]

@rzhade3 Hi, I believe I have addressed your feedback and added some specs. However, I do not have an easy way to record new VCR fixtures so I just mocked the requests with webmock, pulling the example responses from their API docs. If you'd rather have these use VCR would you mind modifying the code and recording them for me? Thanks

[rzhade3]

Thanks for the changes! I'm OK with using Webmock to stub out the request as opposed to re-recording the entire VCR request.

\cc @boveus for final review to see if there's anything more idiomatic we can do with Webmock

[rzhade3]

There are a few Rubocop errors that still need to be fixed. @jeffgran-dox it doesn't appear as if I have permission to push these directly to your branch, could you please accept these suggested changes?

[rzhade3]

@jeffgran-dox Thanks again for the PR, I've released these changes as version 0.23.0 on Rubygems.

[jeffgran-dox]

@rzhade3 excellent, thank you!