Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect note about allowed TXT record removal #37213

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martinpaljak
Copy link

@martinpaljak martinpaljak commented Apr 1, 2025

Why:

After removing the TXT record of a domain I got an e-mail in a few days:

We are unable to find a verification TXT record on yoursite.com. Please verify your domain within 7 days by following our instructions before it becomes unverified.

and I deleted the record based on this line. Thus I believe it to be not correct.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

After removing the TXT record I got an e-mail:

> We are unable to find a verification TXT record on yoursite.com. Please verify your domain within 7 days by following our instructions before it becomes unverified.

and I deleted the record based on this line. Thus I believe it to be not correct.
@Copilot Copilot bot review requested due to automatic review settings April 1, 2025 04:34
Copy link

welcome bot commented Apr 1, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for verifying or approving a domain for your organization. The change removes the instruction suggesting the deletion of the TXT record after achieving domain verification, which appears to have unintended consequences.

Comments suppressed due to low confidence (1)

content/organizations/managing-organization-settings/verifying-or-approving-a-domain-for-your-organization.md:80

  • Removing this instruction should help prevent potential unintended consequences like triggering an unexpected email. Please ensure the documentation clearly states the TXT record should remain to avoid verification issues.
   -1. Optionally, once the "Verified" badge is visible on your organization's profile page, you can delete the TXT entry from the DNS record at your domain hosting service.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 1, 2025
@martinpaljak martinpaljak changed the title Update verifying-or-approving-a-domain-for-your-organization.md Remove incorrect note about allowed TXT record removal Apr 1, 2025
Copy link
Contributor

github-actions bot commented Apr 1, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
organizations/managing-organization-settings/verifying-or-approving-a-domain-for-your-organization.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@Sharra-writes
Copy link
Contributor

Thanks so much for opening a PR! I'll get this triaged for review

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants