-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace misleading documentation about action inputs and outputs #33916
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
This comment was marked as spam.
This comment was marked as spam.
@piotrekkr Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this PR is waiting for technical review. |
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
content/actions/creating-actions/metadata-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
content/actions/creating-actions/metadata-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
content/actions/creating-actions/metadata-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
content/actions/creating-actions/metadata-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
content/actions/creating-actions/metadata-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
content/actions/creating-actions/metadata-syntax-for-github-actions.md
Outdated
Show resolved
Hide resolved
A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days. |
@piotrekkr Thank you for addressing that feedback! I've approved the PR - once you are able to resolve those conflicts, we can get this merged 💛 |
@nguyenalex836 I've rebased this PR on latest code from main. |
@piotrekkr Thank you! Getting this merged now 💛 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Current docs for
inputs
andoutputs
in GitHub action metadata syntax contains some misleading statementsI've tested this
Input ids with uppercase letters are converted to lowercase during runtime.
usingand nothing is converted to lowercase
This is misleading because documentation is about action metadata syntax and note is describing inputs in workflow metadata syntax. This has nothing to do with action inputs, I think.
Again, this paragraph seems to be mixing workflow inputs with action inputs.
Last sentence does not make much sense and I tested it. There is no
INPUT_*
variables present at all with composite actions. I don't even know whatyou can change these inputs manually
part actually means. Inputs are read-only afaik, right?As far as my tests got me,
space
characters are also valid to use in input ids.I tested this with composite and docker action:
and
And inputs in those action did not require any description and actions were run without problem
There seems to be also space allowed in output id. Tested with js action using
core.setOutput('output 1', "test")
and it was returned as action output.Tried and description can be omitted like below without any problems so it seems that it is optional.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Updated docs a bit to reflect what is actually happening with inputs and outputs in actions.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.