Skip to content

C#: mass-enable diff-informed queries phase 2 - getASelected{Source,Sink}Location() { none() } #19758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d10c
Copy link
Contributor

@d10c d10c commented Jun 13, 2025

Stacks on top of earlier PR: #19659
Uses patch from: https://github.com/github/codeql-patch/pull/88/commits/ec5681e740c18c792443099fb3e413446616a0ee

Adds getASelected{Source,Sink}Location() { none() } override to queries that select a dataflow source or sink as a location, but not both.

@github-actions github-actions bot added the C# label Jun 13, 2025
@d10c d10c force-pushed the d10c/csharp/diff-informed-2 branch from 6d8f13c to 9fde7ce Compare June 13, 2025 13:10
@d10c d10c marked this pull request as ready for review June 17, 2025 08:39
@d10c d10c requested a review from a team as a code owner June 17, 2025 08:39
@d10c d10c requested a review from michaelnebel June 17, 2025 08:39
@d10c d10c added the no-change-note-required This PR does not need a change note label Jun 17, 2025
@d10c d10c force-pushed the d10c/csharp/diff-informed-2 branch from 9fde7ce to 634bfa9 Compare June 17, 2025 15:00
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this LGTM, since the 0'th column (the primary) in the select of the query is the sink and since the source is not used as an additional location (i.e. "$@" substitution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants