Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: Define queries more consistently and include all sinks in stats #19222

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Rust: Define queries more consistently and include all sinks in stats #19222

wants to merge 6 commits into from

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Apr 4, 2025

Fixes a number of inconsistencies in the Rust queries:

  • all sinks now extend QuerySink::Range.
    • these are essentially semantic merge conflicts, as we merged the QuerySink class at about the same time as several new queries that were written without it.
  • all query extensions files are included in Stats.qll.
    • thus, all queries will be included in sink stats e.g. on the DCA job.
  • all query extension files use a module now (for tidiness).
  • all queries have extendable sources, where appropriate.
  • more consistent class names in a few cases (slightly improves maintainability).
  • more consistent import order (slightly improves maintainability).

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code labels Apr 4, 2025
@Copilot Copilot bot review requested due to automatic review settings April 4, 2025 17:34
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (14)
  • rust/ql/lib/codeql/rust/security/CleartextLoggingExtensions.qll: Language not supported
  • rust/ql/lib/codeql/rust/security/CleartextTransmissionExtensions.qll: Language not supported
  • rust/ql/lib/codeql/rust/security/SqlInjectionExtensions.qll: Language not supported
  • rust/ql/lib/codeql/rust/security/TaintedPathExtensions.qll: Language not supported
  • rust/ql/lib/codeql/rust/security/WeakSensitiveDataHashingExtensions.qll: Language not supported
  • rust/ql/lib/codeql/rust/security/regex/RegexInjectionExtensions.qll: Language not supported
  • rust/ql/src/queries/security/CWE-020/RegexInjection.ql: Language not supported
  • rust/ql/src/queries/security/CWE-022/TaintedPath.ql: Language not supported
  • rust/ql/src/queries/security/CWE-089/SqlInjection.ql: Language not supported
  • rust/ql/src/queries/security/CWE-311/CleartextTransmission.ql: Language not supported
  • rust/ql/src/queries/security/CWE-312/CleartextLogging.ql: Language not supported
  • rust/ql/src/queries/security/CWE-328/WeakSensitiveDataHashing.ql: Language not supported
  • rust/ql/src/queries/summary/Stats.qll: Language not supported
  • rust/ql/test/query-tests/security/CWE-020/RegexInjectionSink.ql: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@geoffw0 geoffw0 mentioned this pull request Apr 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geoffw0