Rust: Take where clauses into account in path resolution
#19193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/path-resolution-where-clause
branch
from
6fc9369 to
9117247
Compare
hvitved
force-pushed
the
rust/path-resolution-where-clause
branch
from
9117247 to
f17ffe3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a stray whitespace issue in a comment marker in the type inference tests and adds a new test module to verify that Rust’s path resolution correctly takes into account where clauses.
- Fixed whitespace in a comment marker in the type inference test case
- Added a new module (m24) in path resolution tests to exercise trait bounds in where clauses
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/test/library-tests/type-inference/main.rs | Trimmed stray whitespace in the comment marker for a method call to ensure test annotations are correctly formatted. |
| rust/ql/test/library-tests/path-resolution/main.rs | Introduced module m24 with trait definitions and implementations to test path resolution logic involving where clauses. |
Files not reviewed (4)
- rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported
- rust/ql/lib/utils/test/PathResolutionInlineExpectationsTest.qll: Language not supported
- rust/ql/test/library-tests/path-resolution/path-resolution.expected: Language not supported
- rust/ql/test/library-tests/variables/variables.ql: Language not supported
| let impl_obj = Implementor; // $ item=I118 | ||
| let generic = GenericStruct { data: impl_obj }; // $ item=I115 | ||
|
|
||
| generic.call_trait_a(); // $ MISSING: item=I116 |
There was a problem hiding this comment.
The annotation '$ MISSING: item=I116' on this line is inconsistent with other markers in the file. If it is not intended, please remove or correct it to match the expected format.
Suggested change
| generic.call_trait_a(); // $ MISSING: item=I116 | |
| generic.call_trait_a(); // $ item=I116 |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used Copilot Agent to generate the test case, which mostly worked fine, except it inserted a stray whitespace in one of the comment markers, which took my quite a while to identify. To prevent this from happening again, I've inserted appropriate trimming of the markers.