Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update suites for Actions queries #18356

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Update suites for Actions queries #18356

merged 2 commits into from
Dec 20, 2024

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Dec 20, 2024

This PR updates the suite files for the Actions queries:

= Added actions-security-extended.qls, which is needed for Default Setup.

  • Made actions-security-extended.qls just import actions-code-scanning.qls, since the set of queries is the same for now.
  • Made actions-security-and-quality.qls just import actions-security-extended.qls, since the set of queries is the same for now.
  • Replaced "Actions" with "GitHub Actions" in the suite descriptions, to match how we display the language name in the Code Scanning UI.

I also marked the UnversionedImmutableAction.ql query with the internal tag, and added an exclusion for internal queries in the suite file. This query refers to a feature that is not yet generally available, so it's causing customer confusion.

@Copilot Copilot bot review requested due to automatic review settings December 20, 2024 19:41
@dbartol dbartol requested a review from a team as a code owner December 20, 2024 19:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (6)
  • actions/ql/src/Security/CWE-829/UnversionedImmutableAction.ql: Language not supported
  • actions/ql/src/codeql-suites/actions-all.qls: Language not supported
  • actions/ql/src/codeql-suites/actions-bughalla.qls: Language not supported
  • actions/ql/src/codeql-suites/actions-code-scanning.qls: Language not supported
  • actions/ql/src/codeql-suites/actions-security-and-quality.qls: Language not supported
  • actions/ql/src/codeql-suites/actions-security-extended.qls: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@github-actions github-actions bot added the Actions Analysis of GitHub Actions label Dec 20, 2024
@dbartol dbartol requested review from adityasharad and aibaars and removed request for a team December 20, 2024 19:42
@dbartol dbartol added the no-change-note-required This PR does not need a change note label Dec 20, 2024
@dbartol dbartol merged commit 2aba49f into main Dec 20, 2024
10 of 11 checks passed
@dbartol dbartol deleted the dbartol/actions-suites branch December 20, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants