Rust: reinstate extraction of test code #18347
Merged
+46
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users will still be able to opt out: * for unit tests, by providing the `cargo_cfg_overrides=-test` extractor option * for integration tests, by excluding the test files from the analysis using `paths-ignore` in the codescanning configuration file We may want to revisit whether we want a single option for both. Also further work will be needed to restrict our security queries to non-test code on the QL side.
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- rust/ql/integration-tests/file-exclusions/source_archive.default.expected: Language not supported
- rust/ql/integration-tests/options/cfg/functions.expected: Language not supported
- rust/ql/integration-tests/options/cfg/functions.override.expected: Language not supported
Comments suppressed due to low confidence (2)
rust/extractor/src/config.rs:151
- Ensure that test coverage includes scenarios where non-disjoint cfg overrides are provided.
let global = CfgDiff::new(enabled_cfgs, disabled_cfgs)
rust/extractor/src/config.rs:20
- Removing the warn log might lead to a lack of visibility for potential issues. Consider re-adding the warn log for non-disjoint cfg overrides.
use std::collections::HashSet;
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
| codeql.database.create(extractor_option=f"cargo_cfg_overrides={overrides}") | ||
|
|
||
| @pytest.mark.ql_test(expected=".override.expected") | ||
| def test_ducplicate_cfg_overrides(codeql, rust): |
There was a problem hiding this comment.
The function name 'test_ducplicate_cfg_overrides' contains a typo. It should be 'test_duplicate_cfg_overrides'.
Suggested change
| def test_ducplicate_cfg_overrides(codeql, rust): | |
| @pytest.mark.ql_test(expected=".override.expected") | |
| def test_duplicate_cfg_overrides(codeql, rust): |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
aibaars
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users will still be able to opt out:
cargo_cfg_overrides=-testextractor optionpaths-ignorein the codescanning configuration fileWe may want to revisit whether we want a single option for both. Also further work will be needed to restrict our security queries to non-test code on the QL side.