Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared: Add CFG consistency check for scopes with missing entry points #17585

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Sep 25, 2024

No description provided.

@hvitved hvitved force-pushed the shared/cfg-scope-no-first-consistency branch from f4f2c85 to f341b10 Compare September 25, 2024 14:44
@github-actions github-actions bot added C# Ruby Rust Pull requests that update Rust code labels Sep 25, 2024
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@hvitved hvitved force-pushed the shared/cfg-scope-no-first-consistency branch from f341b10 to f389a88 Compare September 26, 2024 09:10
@hvitved hvitved marked this pull request as ready for review September 26, 2024 10:04
@hvitved hvitved requested review from a team as code owners September 26, 2024 10:04
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Sep 26, 2024
@hvitved hvitved requested a review from aibaars September 26, 2024 10:55
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me!

@hvitved hvitved merged commit 7c473c3 into github:main Sep 26, 2024
55 of 57 checks passed
@hvitved hvitved deleted the shared/cfg-scope-no-first-consistency branch September 26, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note Ruby Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants