Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#/Java: Content based model generation improvements. #17521

Merged
merged 16 commits into from
Sep 30, 2024

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Sep 19, 2024

In this PR we make the following content based model generator improvements stated below.
With these changes we are now ready to re-generate the models for the Java SDK using the "mixed" query mentioned below.

  • Instead of completely excluding an API from content based model generation, if it overall has "too many" summaries, we now consider the number of summaries pr. parameter instead, and only exclude an API and parameter combination in case it could yield more than three summaries.
  • The requirement for when we accept synthetic fields has been made less tight. Access paths containing a synthetic field should no longer be identical to form a chain of synthetics. The synthetic fields should now just be mentioned in the same order in some other access path (but a chain should still be formed).
  • Content based summaries now have their own provenance dfc-generated.
  • The lifting logic for the content based summaries has been improved.
  • A new "mixed" model generator query has been introduced: If at least one content based model is generated for an API we use the content based model; Otherwise we attempt to generate non-content based models and use them instead. A query for mixed neutrals has also been introduced.
  • The model generator script has been updated such that we can create mixed summaries/neutrals.

@michaelnebel michaelnebel force-pushed the modelgen/moreimprovements branch 2 times, most recently from 91102a3 to c869e4d Compare September 23, 2024 09:22
@michaelnebel michaelnebel force-pushed the modelgen/moreimprovements branch from 2f763f7 to e6a97b9 Compare September 26, 2024 11:33
@michaelnebel michaelnebel force-pushed the modelgen/moreimprovements branch from e6a97b9 to 0b39c5b Compare September 27, 2024 07:23
@michaelnebel
Copy link
Contributor Author

DCA looks good!

@michaelnebel michaelnebel marked this pull request as ready for review September 27, 2024 07:27
@michaelnebel michaelnebel requested review from a team as code owners September 27, 2024 07:27
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Sep 27, 2024
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments.

@michaelnebel michaelnebel merged commit 6f74387 into github:main Sep 30, 2024
52 checks passed
@michaelnebel michaelnebel deleted the modelgen/moreimprovements branch September 30, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants