-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#/Java: Content based model generation improvements. #17521
Merged
michaelnebel
merged 16 commits into
github:main
from
michaelnebel:modelgen/moreimprovements
Sep 30, 2024
Merged
C#/Java: Content based model generation improvements. #17521
michaelnebel
merged 16 commits into
github:main
from
michaelnebel:modelgen/moreimprovements
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharp/ql/src/utils/modelgenerator/internal/CaptureModels.qll
Dismissed
Show dismissed
Hide dismissed
michaelnebel
force-pushed
the
modelgen/moreimprovements
branch
2 times, most recently
from
September 23, 2024 09:22
91102a3
to
c869e4d
Compare
…t more than three summaries.
michaelnebel
force-pushed
the
modelgen/moreimprovements
branch
from
September 26, 2024 11:33
2f763f7
to
e6a97b9
Compare
…ed model generation.
…ixed model generator queries.
michaelnebel
force-pushed
the
modelgen/moreimprovements
branch
from
September 27, 2024 07:23
e6a97b9
to
0b39c5b
Compare
DCA looks good! |
michaelnebel
added
the
no-change-note-required
This PR does not need a change note
label
Sep 27, 2024
hvitved
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments.
shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll
Outdated
Show resolved
Hide resolved
shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll
Outdated
Show resolved
Hide resolved
shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll
Outdated
Show resolved
Hide resolved
shared/mad/codeql/mad/modelgenerator/internal/ModelGeneratorImpl.qll
Outdated
Show resolved
Hide resolved
hvitved
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we make the following content based model generator improvements stated below.
With these changes we are now ready to re-generate the models for the Java SDK using the "mixed" query mentioned below.
dfc-generated
.